Skip to content

feat(FOUR-34469): require version_name on deploy upsert updates - #9181

Merged
caleeli merged 11 commits into
feature/FOUR-34328from
FOUR-34469
Nov 20, 2026
Merged

caleeli merged 11 commits into
feature/FOUR-34328from
FOUR-34469

Conversation

@gproly

@gproly gproly commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Record deploy updates in package-versions VersionHistory (subject), matching the UI publish flow. Apply to deploy-screen, deploy-script, and deploy-process when the asset already exists.

https://processmaker.atlassian.net/browse/FOUR-34469

ci:package-skeleton:FOUR-34469

Record deploy updates in package-versions VersionHistory (subject),
matching the UI publish flow. Apply to deploy-screen, deploy-script,
and deploy-process when the asset already exists.

https://processmaker.atlassian.net/browse/FOUR-34469
@cursor

cursor Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes deploy API contracts for all upsert paths and depend on package-versions schema; failures or mis-association of version history could block automated deploys.

Overview
Deploy upserts for processes, screens, and scripts now align with UI publish flow by requiring version_name (and optional version_description) when updating an existing asset, and writing a VersionHistory record via the new DeployVersionName service and shared AppliesDeployVersionName controller trait.

Update requests are rejected with 422 if package-versions is missing when an update is attempted, or if version_name is omitted. After save, history is tied to the newly published version when one exists; script redeploys with unchanged code and an active draft can still record history on the current published version.

Feature tests cover validation and persistence; minor test harness tweaks fix script executor assertions and MySQL transaction issues in DataConnectorsServerTest.

Reviewed by Cursor Bugbot for commit 4850290. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@cursor
cursor Bot requested a review from caleeli November 18, 2026 20:36
…ites

- Align deploy Nayra executor test with ScriptExecutorResolver contract
- Grant create-scripts permission in modules duplicate script test
- Disable DB transactions in DataConnectorsServerTest to avoid MySQL 1412
- Skip duplicate-request console tests until the artisan command ships

https://processmaker.atlassian.net/browse/FOUR-34469
… test

Duplicate validates Script::rules() and requires script_category_id in the
request body; align the modules execution_mode test with existing duplicate tests.

https://processmaker.atlassian.net/browse/FOUR-34469

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 44e30d8. Configure here.

… update

Pass version_name on the second deploy-screen POST so preview_presets tests
align with FOUR-34469 upsert validation.

https://processmaker.atlassian.net/browse/FOUR-34469
@cursor
cursor Bot requested a review from marcoAntonioNina November 20, 2026 15:44
…deploy

When a script update has a draft and unchanged code, HasVersioning may skip
publishing a new row; attach VersionHistory to the current published version
instead of returning 422. Add deploy script feature coverage for the case.

https://processmaker.atlassian.net/browse/FOUR-34469
@decisions-sonarqube

Copy link
Copy Markdown

@caleeli
caleeli merged commit 39c254f into feature/FOUR-34328 Nov 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants